Enhance loadPageSize() test to verify valid page size #1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: anod <171704+anod@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update room version to 2.8.4 based on review feedback
Enhance loadPageSize() test to verify valid page size
Dec 23, 2025
anod
added a commit
that referenced
this pull request
Jan 14, 2026
* Initial plan * Enhance loadPageSize test to verify valid page size Co-authored-by: anod <171704+anod@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: anod <171704+anod@users.noreply.github.com>
lalitb
added a commit
that referenced
this pull request
Feb 10, 2026
* Update room version to 2.8.4 In addition bump gradle and AGP version * Fix java version * Update lib/android_build/maesdk/src/main/java/com/microsoft/applications/events/OfflineRoom.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Enhance loadPageSize() test to verify valid page size (#1395) * Initial plan * Enhance loadPageSize test to verify valid page size Co-authored-by: anod <171704+anod@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: anod <171704+anod@users.noreply.github.com> * Update codeql to run on java 17 * Fix thread-safety in initPageSize() using double-checked locking with static lock (#1396) * Initial plan * Add thread-safety to initPageSize() using double-checked locking Co-authored-by: anod <171704+anod@users.noreply.github.com> * Use static lock object for thread-safety in initPageSize() Co-authored-by: anod <171704+anod@users.noreply.github.com> * Add concurrent test for thread-safe page size initialization Co-authored-by: anod <171704+anod@users.noreply.github.com> * Use ExecutorService instead of raw threads in concurrent test Co-authored-by: anod <171704+anod@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: anod <171704+anod@users.noreply.github.com> * Update modules, fix Android build, add test case * Add invalid character test for serializer * Update documentation to reflect Android API 23+ and build requirements (#1410) * Initial plan * Update documentation with Android API 23+ requirements Co-authored-by: anod <171704+anod@users.noreply.github.com> * Update Java version requirement to Java 17 for Gradle 8.5 Co-authored-by: anod <171704+anod@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: anod <171704+anod@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: anod <171704+anod@users.noreply.github.com> Co-authored-by: Tom Tan <Tom.Tan@microsoft.com> Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #1394 to strengthen the
loadPageSize()test validation. The original test only checked the return value wasn't -1, missing validation of actual page size properties.Changes
loadPageSize()returns a positive value and is a power of 2assertThat(pageSize, Matchers.greaterThan(0L))- ensures valid page sizeassertThat(pageSize & (pageSize - 1), Matchers.is(0L))- confirms power-of-2 (typical: 4096)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.